pingcap / pingcap/tidb

Make the DDL checks the same for the command (ddl_api.go) and the execution (ddl_worker.go)

Open
#45,540 0 comments 1 reaction 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

For checking if a DDL statement is OK, it is first checked in the session of the statement, and then it enters the DDL queue.
When the DDL job is then picked from the queue, it is checked again. These checks are not always the same, and there are cases where some checks are missing in one of them.

This task is to make sure that the checks are the same for both the session and the ddl worker, probably by refactor some checks, so they can be used by both.

Example: ADD PARTITION does checks differently in the DDL Session vs the DDL Worker.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.