pingcap / pingcap/tidb

lightning, importinto: diskquota checking and SST writer should be executed synchronously

Open
#44,925 0 comments 0 reactions 0 assignees View on GitHub
component/lightning severity/moderate type/bug
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report

Please answer these questions before submitting your issue. Thanks!

### 1. Minimal reproduce step (Required)
1. There will be race between sstable.(*blockWriter).estimatedSize and sstable.(*blockWriter).store
2. When we write to disks while sorting, diskquota is no longer guaranteed.

### 2. What did you expect to see? (Required)
block writing while do diskquota checking.
### 3. What did you see instead (Required)

### 4. What is your TiDB version? (Required)

master

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.