pingcap / pingcap/tidb

MPP dag request's encode type ignored "tidb_enable_chunk_rpc" system variable

Open
#44,183 1 comment 0 reactions 0 assignees View on GitHub
severity/moderate sig/execution type/bug
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report
When review code, found this issue:
https://github.com/pingcap/tidb/blob/b56c5b6e110c67fcd0facaea3b3e97d4d36d5861/executor/mpp_gather.go#L88
We'll use chunk encoding now even tidb_enable_chunk_rpc is false.
Manually test shows that this won't affect query behaviors, and thus not noticable to users.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.