pingcap / pingcap/tidb

The use of ErrPausedDDLJob is problematic

Open
#43,699 3 comments 0 reactions 0 assignees View on GitHub
first-time-contributor severity/minor sig/sql-infra type/bug
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report

Please answer these questions before submitting your issue. Thanks!

### 1. Minimal reproduce step (Required)

```
ErrCannotPauseDDLJob: mysql.Message("Job [%v] can't be paused now", nil),
ErrCannotResumeDDLJob: mysql.Message("Job [%v] can't be resumed", nil),
ErrPausedDDLJob: mysql.Message("Job [%v] already paused", nil),
```
I think we need use GenWithStackByArgs when calling `ErrPausedDDLJob`. But I don't see this in code. We use it like `return dbterror.ErrPausedDDLJob`.

### 2. What did you expect to see? (Required)
`[INFO] [ddl_worker.go:818] ["[ddl] run DDL job failed, sleeps a while then retries it."]...[error="[ddl:8262]Job [id] already paused"]`

### 3. What did you see instead (Required)
`[INFO] [ddl_worker.go:818] ["[ddl] run DDL job failed, sleeps a while then retries it."]...[error="[ddl:8262]Job [%v] already paused"]`

### 4. What is your TiDB version? (Required)

master

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.