pingcap / pingcap/tidb

lightning: confusing log of conflict error

Open
#42,816 0 comments 0 reactions 0 assignees View on GitHub
affects-5.2 affects-5.3 affects-5.4 affects-6.1 affects-6.5 affects-7.1 component/lightning severity/minor type/bug
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report

Please answer these questions before submitting your issue. Thanks!

### 1. Minimal reproduce step (Required)

Enable duplicate detection and use lightning to import data with conflict errors.

### 2. What did you expect to see? (Required)

Log is clear.

### 3. What did you see instead (Required)
```
Import Data Error Summary:
+---+---------------------+-------------+------------------------------------- ~
| # | ERROR TYPE | ERROR COUNT | ERROR DATA TABLE ~
+---+---------------------+-------------+------------------------------------- ~
| 1 | Unique Key Conflict | 830 | `lightning_task_info`.`conflict_erro ~
+---+---------------------+-------------+------------------------------------- ~

[2023/04/04 17:57:09.312 +08:00] [INFO] [import.go:1919] ["skip full compaction"]
[2023/04/04 17:57:09.312 +08:00] [INFO] [import.go:519] ["the whole procedure completed"] [takeTime=11.803972053s] []
[2023/04/04 17:57:09.312 +08:00] [WARN] [errormanager.go:491] ["Detect 830 data type errors in total, please refer to table `lightning_task_info`.`conflict_error_v1` for more details"]
[2023/04/04 17:57:09.325 +08:00] [INFO] [main.go:106] ["tidb lightning exit"] [finished=true]
```

Import Data Error Summary is truncated.

`"Detect 830 data type errors in total"` should be `"Detect 830 data conflict errors in total"`.

### 4. What is your TiDB version? (Required)

master

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.