pingcap / pingcap/tidb

Improve test-coverage of sessionctx/variable/variable.go

Open
#38,180 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement

The sessionctx/variable package still has quite low test coverage (~45%). A lot of this is because the individual sysvars (sysvar.go) don't always have tests. But there is no reason why the API in variable.go (currently at 91.9%) can't be at 100%. It is used by a lot of areas of the server, and undefined behaviors have a high risk of breaking upgrade/downgrade.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.