pingcap / pingcap/tidb

`FlushClientConn` is traced incorrectly

Open
#37,394 0 comments 0 reactions 0 assignees View on GitHub
component/metrics severity/minor sig/sql-infra type/bug
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report

Please answer these questions before submitting your issue. Thanks!

### 1. Minimal reproduce step (Required)

The following code is meaningless.

https://github.com/pingcap/tidb/blob/803677741353c22cce85cee05e0322a1cc41bd54/server/conn.go#L1426

### 2. What did you expect to see? (Required)

The region should start when entering the function.

### 3. What did you see instead (Required)

It starts and ends immediately at the defered call.

### 4. What is your TiDB version? (Required)

master

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.