pingcap / pingcap/tidb

Disable start-ts parameters during PiTR restore

Open
#37,030 0 comments 0 reactions 0 assignees View on GitHub
type/enhancement
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Enhancement
When doing br PiTR restore, user specifies --full-backup-storage for snapshot backup, and --storage for log backup, in this case start-ts is the backupts of the snapshot backup. Currently user can specify --start-ts parameter for PiTR restore , though is seems ignored, it is confusing.
![6OiUBQfQrf](https://user-images.githubusercontent.com/7403864/183890632-24586f7b-1f2d-4322-8f37-08124eaf739a.jpg)

Suggestion:
1. In br restore point help, make it clear the start-is parameter is only for log only restore.
2. Forbid user to specify start-ts parameters during PiTR restore (if full-backup-storage parameter is specified)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.