Clean up old version comments like /*!40100 DEFAULT CHARACTER SET utf8mb4 */
- Dominant language
- Go
- Stars
- 40.5k
- Forks
- 6.2k
- PR merge metrics
- PR metrics pending
Description
## Enhancement
TiDB is aiming for compatibility with MySQL 5.7/8.0, so outputting version comments < 5.7 seems unnecessary.
Notice that there might be use of version comments in the repository aiming for migrating data to TiDB, where use of older version comments may make sense.
I propose that all the version comments mentioning versions <= 5.6 are removed and just output as normal non-commented text/options, i.e. instead of `/*!40100 DEFAULT CHARACTER SET utf8mb4 */` it would just be `DEFAULT CHARACTER SET utf8mb4`
Contributor guide
Research direction
No source file or test is named. Search the Go SQL output paths for version comments such as /*!40100 DEFAULT CHARACTER SET utf8mb4 */; verify that comments for versions <=5.6 become ordinary options while migration-oriented comments remain supported, then add focused tests for both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, mysql, sql
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100