pingcap / pingcap/tidb

variable `tls_version` does not contain TLSv1.3 though TiDB supports it

Open
#35,826 0 comments 0 reactions 1 assignee Claimed by @dveeden View on GitHub
severity/moderate sig/sql-infra type/bug
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Bug Report

Please answer these questions before submitting your issue. Thanks!

### 1. Minimal reproduce step (Required)

```
my:root@127.0.0.1:4000=> SHOW GLOBAL VARIABLES LIKE 'tls_version';
Variable_name | Value
---------------+-----------------------
tls_version | TLSv1,TLSv1.1,TLSv1.2
(1 row)
```

### 2. What did you expect to see? (Required)

For default setting, TLSv1.3 should be included since it's supported. But actually the supported tls versions could be modified and currently it's just a noop variable https://github.com/pingcap/tidb/blob/e2b55640c179c3fa2d3ce4cca58999c47d7eeabe/sessionctx/variable/noop.go#L131
it might need to be changed to a real variable.

### 3. What did you see instead (Required)

### 4. What is your TiDB version? (Required)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.