pingcap / pingcap/tidb

Do not allow br full restore if table structure exists

Open
#32,615 2 comments 0 reactions 0 assignees View on GitHub
component/br help wanted type/feature-request
Dominant language
Go
Stars
40.5k
Forks
6.2k
PR merge metrics
PR metrics pending

Description

## Feature Request

**Is your feature request related to a problem? Please describe:**

Currently, when trying to br restore a table after run query "delete from t1;" and "truncate table t1;" is different:

```
CREATE TABLE `t1` (`a` int(11) NOT NULL, PRIMARY KEY (`a`));
insert into t1 values (1), (2);
br backup t1;
delete from t1;
restore t1 => BR:Restore:ErrRestoreChecksumMismatch
```
```
CREATE TABLE `t1` (`a` int(11) NOT NULL, PRIMARY KEY (`a`));
insert into t1 values (1), (2);
br backup t1;
truncate table t1;
restore t1 => Success
```

**Describe the feature you'd like:**

After execute query "delete from t1;" or "truncate table t1; br restore should not allow user to restore to the table t1, as table structure still exists in this cases.

**Describe alternatives you've considered:**

**Teachability, Documentation, Adoption, Migration Strategy:**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.