pingcap / pingcap/tidb-operator
Optimize the validation of deleting pd instance
Open
Nobody has claimed this yet.
v2
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Now it's easy to break pd clusters by deleting more than 1/2 pd instances. We have to forbid the deletion if the pd number is less than the 1/2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Go validation or reconciliation logic that handles deleting PD instances in the Kubernetes operator. Trace how the current PD count is checked and identify the relevant tests; done means deletion is rejected when it would leave fewer than half of the PD instances.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- databases, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100