pingcap / pingcap/tidb-operator
Backup spec does not have nodeSelector field
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Bug Report
What version of Kubernetes are you using?
What version of TiDB Operator are you using?
Current all version
What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods?
What's the status of the TiDB cluster pods?
What did you do?
Deploy Backup
What did you expect to see?
Backup spec can configure nodeSelector just like TiDB-Cluster spec, see
https://github.com/pingcap/tidb-operator/blob/v1.5.0/pkg/apis/pingcap/v1alpha1/types.go#L287
and
https://github.com/pingcap/tidb-operator/blob/v1.5.0/pkg/apis/pingcap/v1alpha1/types.go#L1074
PS: Kubernetes officially reject the deprecate of nodeSelector, see issue https://github.com/kubernetes/kubernetes/issues/82331
What did you see instead?
Backup spec does not have nodeSelector field, see
https://github.com/pingcap/tidb-operator/blob/v1.5.0/pkg/apis/pingcap/v1alpha1/types.go#L1895-L1992
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/apis/pingcap/v1alpha1/types.go, comparing the TiDB-Cluster nodeSelector fields around lines 287 and 1074 with the Backup spec around lines 1895-1992. Confirm how the Backup API represents its pod scheduling options, then verify that Backup specs expose nodeSelector consistently with the expected Kubernetes configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100