pingcap / pingcap/tidb-operator
Issue with the indent in deployment-discovery template for resources
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
This https://github.com/pingcap/tidb-operator/blob/master/charts/tidb-cluster/templates/discovery-deployment.yaml#L50
should not be 12 rather 10.
Suggestion:
{{- with .Values.discovery.resources }}
resources:
{{ toYaml . | nindent 10 }}
{{- end }}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open charts/tidb-cluster/templates/discovery-deployment.yaml at line 50 and inspect the discovery resources block. Change the indentation argument from 12 to 10 as suggested, then render the chart to verify the generated Kubernetes Deployment has correctly indented resources.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100