pingcap / pingcap/tidb-operator

[Enhance] Discard statefulset rollingUpdate update strategies.

Open
#4,848 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
1.3k
Forks
540
Avg merge
3d 2h
Merged PRs (30d)
18

Description

Feature Request

Is your feature request related to a problem? Please describe:
Old discussion issue https://github.com/pingcap/tidb-operator/issues/4130.

I learned from es operator and kafka operator two projects, which all good operator project. They all discard statefulset rollingUpdate update strategies.

ES Operator project related issue:
Use OnDelete instead of RollingUpdate to roll more than 1 pod at a time
It use ondelete strategies instead of sts rollingupdate strategy.

Kafka Operator project related issue and pr:
[Enhancement] Allow scaling down of a pods in the middle of the cluster
Remove StatefulSets from ZooKeeper
It use custom podset crd instead of sts crd.

Describe the feature you'd like:
We should follow the good project, of course take the smallest changes, so i advice that take the ondelete update strategy instead of rollingUpdate strategy and customize tidb operator own update logic.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the earlier TiDB Operator discussion in issue #4130 and the linked Elasticsearch and Strimzi examples. Identify where StatefulSet rollingUpdate strategies and TiDB Operator update behavior are handled. Done would mean using an ondelete strategy and providing the operator's own update logic, but the issue does not name files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.