pingcap / pingcap/tidb-operator

do not lost the error when checking tidb health

Open
#4,772 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
1.3k
Forks
540
Avg merge
3d 2h
Merged PRs (30d)
18

Description

https://github.com/pingcap/tidb-operator/blob/e60a3ea2003965fa99f763323618cb1c452ad6e3/pkg/controller/tidb_control.go#L73

​​​​when upgrading tidb, it keep unhealth and can not know what happens (tidb-1 already running and ready)
20221109-133302

20221109-133403

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at pkg/controller/tidb_control.go#L73 and inspect how the TiDB health check handles errors during an upgrade. Reproduce the reported case where tidb-1 is running and ready but the cluster remains unhealthy, then verify that the underlying health-check error is preserved and visible.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.