pingcap / pingcap/tidb-operator
Add support for storage.enable-ttl to tikv config
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Feature Request
I would like to run tikv (without tidb) with ttl enabled. This is a feature in tikv, but the configuration value to enable it is missing in the tidb-operator manifest structures, and therefore not passed on to tikv.
I am able to work on this feature. But would like to discuss implementation details with the tidb-operator team. A naïve implementation would just pass the configuration value, however, the big warning on the enable-ttl documentation shows that it should not be used for tidb clusters. So I suspect we would want to have some check that denies manifests with enable-ttl=true while tidb is also enabled?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pkg/apis/pingcap/v1alpha1/tikv_config.go near line 555 and compare the TiKV enable-ttl documentation linked in the issue. Trace how TikV configuration is represented and passed through manifests, then determine the required handling when TiDB is enabled. Done means the setting is represented and propagated, with the documented unsafe combination addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100