pingcap / pingcap/tidb-operator
Users want to customize tags for docker images on TiDB operator
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Feature Request
Is your feature request related to a problem? Please describe:
Because the TiDB operator will always fetch the docker image with {baseImage}:{spec.version} so today users have to set the spec.version to master-1655403302-89a8cabf otherwise user company docker repo will not find the docker image.
Example: https://github.com/pingcap/tidb-operator/blob/c77aea715b4549fda85c5df7baf33b792508b208/pkg/apis/pingcap/v1alpha1/tidbcluster.go#L55.
And then spec.version is also used for checking whether users could enable some features: https://github.com/pingcap/tidb-operator/blob/master/pkg/manager/member/utils.go#L442
Describe the feature you'd like:
Describe alternatives you've considered:
Teachability, Documentation, Adoption, Migration Strategy:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/apis/pingcap/v1alpha1/tidbcluster.go around the referenced image and version fields, then inspect pkg/manager/member/utils.go around the feature checks. Trace how spec.version is used for image tags and capability checks; done should allow a separate customizable image tag without breaking those checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, go, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100