pingcap / pingcap/tidb-operator

tidb-operator should validate pd/tikv config

Open
#4,532 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
1.3k
Forks
540
Avg merge
3d 2h
Merged PRs (30d)
18

Description

Bug Report

What version of Kubernetes are you using?
v1.21.10-gke.2000

What version of TiDB Operator are you using?
v1.3.2

What did you do?
I've applied the following config.

kind: TidbCluster
spec:
  version: v5.4.0
  pd:
    baseImage: pingcap/pd
    config:
      schedule:
         leader-schedule-policy: "count"

What did you expect to see?
I expected to see operator to reject applying CR as leader-schedule-policy is not a valid parameter.

What did you see instead?
tidb-operator accepted invalid CR and generated the following config map:

data:
config-file: |
[schedule]

startup-script: |
...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are named. Start by reproducing the shown TidbCluster manifest on Kubernetes and trace how tidb-operator handles pd/tikv config; done means rejecting the invalid leader-schedule-policy parameter instead of generating an empty config section.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.