pingcap / pingcap/tidb-operator
Consider enable prometheusReloader and reloader by default
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Feature Request
The feature of reloading prometheus rules and config files are commonly needed, can we enable it by default rather than configure it in tidbmonitor.spec?
Is your feature request related to a problem? Please describe:
Describe the feature you'd like:
enable PrometheusReloader and reloader by default.
Describe alternatives you've considered:
- merge prometheusReloader and reloader's function into one container to reload rules and configs.(this is what prometheus-config-reloader is doing now) But we should consider that reloader also provide an ui for rules configuration
Teachability, Documentation, Adoption, Migration Strategy:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the tidbmonitor.spec configuration for prometheusReloader and reloader, then read the monitoring README section describing the reloader's rule-configuration UI. Determine the compatibility and configuration impact of enabling both by default, and verify that the resulting behavior matches the documented feature request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes, prometheus
- Domain
- infrastructure, observability-sre
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100