pingcap / pingcap/tidb-operator
Optimize tidbmonitor service discover configuration.
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Bug Report
What did you do?
Now tidbmonitor use pod role in kubernetes_sd_config configuration , when pod is in a notready situation , should we need to remove it from targets list?
And pod role will discovers all pods and exposes their containers as targets.Is there a performance loss for many pod resources?
For example we can set __meta_kubernetes_pod_ready to true or use endpoints,endpointslices role instead.
What did you expect to see?
What did you see instead?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating tidbmonitor's kubernetes_sd_config and reviewing how the pod role produces targets, including not-ready pods and container targets. Compare the pod, endpoints, and endpointslices roles, then measure or otherwise verify target behavior and resource impact. Done means the selected configuration and its readiness behavior are documented and validated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100