pingcap / pingcap/tidb-operator

panic time and time again if use advance statefulset

Open
#4,398 0 comments 0 reactions 1 assignee View on GitHub

@KanShiori is already working on this.

Since Mar 10, 2022.

status/help-wanted type/bug
Dominant language
Go
Stars
1.3k
Forks
540
Avg merge
3d 2h
Merged PRs (30d)
18

Description

Bug Report

What version of Kubernetes are you using?

What version of TiDB Operator are you using?

v1.2.6

What did you do?

observe controller restarts

kNAME                                               READY   STATUS    RESTARTS   AGE
advanced-statefulset-controller-7786b96bcc-bw2gk   1/1     Running   1          30h
tidb-controller-manager-55c464db78-nqfpj           1/1     Running   20         30h

check logs
k logs tidb-controller-manager-55c464db78-nqfpj -p -n tidb-admin

E0208 06:36:18.467917       1 runtime.go:76] Observed a panic: unreachable
goroutine 4521 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic(0x1b1b2e0, 0x2247850)
	k8s.io/apimachinery@v0.0.0/pkg/util/runtime/runtime.go:74 +0xa3
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
	k8s.io/apimachinery@v0.0.0/pkg/util/runtime/runtime.go:48 +0x82
panic(0x1b1b2e0, 0x2247850)
	runtime/panic.go:679 +0x1b2
github.com/pingcap/advanced-statefulset/client/apis/apps/v1/helper.(*hijackWatch).receive(0xc001116090)
	github.com/pingcap/advanced-statefulset/client@v1.16.0/apis/apps/v1/helper/hijack.go:165 +0x2c5
created by github.com/pingcap/advanced-statefulset/client/apis/apps/v1/helper.newHijackWatch
	github.com/pingcap/advanced-statefulset/client@v1.16.0/apis/apps/v1/helper/hijack.go:140 +0x9f
panic: unreachable [recovered]
	panic: unreachable

goroutine 4521 [running]:
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
	k8s.io/apimachinery@v0.0.0/pkg/util/runtime/runtime.go:55 +0x105
panic(0x1b1b2e0, 0x2247850)
	runtime/panic.go:679 +0x1b2
github.com/pingcap/advanced-statefulset/client/apis/apps/v1/helper.(*hijackWatch).receive(0xc001116090)
	github.com/pingcap/advanced-statefulset/client@v1.16.0/apis/apps/v1/helper/hijack.go:165 +0x2c5
created by github.com/pingcap/advanced-statefulset/client/apis/apps/v1/helper.newHijackWatch
	github.com/pingcap/advanced-statefulset/client@v1.16.0/apis/apps/v1/helper/hijack.go:140 +0x9f

guest it panic at Bookmark type
Screen Shot 2022-02-08 at 4 52 26 PM

What did you expect to see?
should have no panic
What did you see instead?
may panic time and time

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.