pingcap / pingcap/tidb-operator

Backup CR generated by BackupSchedule support Local Time

Open
#4,302 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
1.3k
Forks
540
Avg merge
3d 2h
Merged PRs (30d)
18

Description

Feature Request

Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

BackupSchedule CR will generate Backup CR automatically named {backupschedule.name}-{formated-time}, but the timezone of formated-time is UTC, which does not match the timezone in tidb-operator. ref:
https://github.com/pingcap/tidb-operator/blob/1e54f2697b65543414ec29202840455382f69380/pkg/apis/pingcap/v1alpha1/backup_schedule.go#L21-L23

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced BackupSchedule API definition in pkg/apis/pingcap/v1alpha1/backup_schedule.go and trace where Backup CR names are generated. Confirm how tidb-operator represents its timezone, then verify that generated names use the intended local time instead of UTC.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.