pingcap / pingcap/tidb-operator
validate tiflash spec config part
Open
@KanShiori is already working on this.
Since Mar 30, 2022.
area/webhook
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
if write it as:
config: |
TOML-format...
the tc can be apply success
but operator failed to work like
E0705 07:07:22.933371 1 tidb_monitor_controller.go:92] TidbMonitor: testbed-gn9qg/tc, sync failed, err: get tm[testbed-gn9qg/tc]'s target tc[testbed-gn9qg/tc] failed, err: v1alpha1.TidbCluster.Spec: v1alpha1.TidbClusterSpec.TiFlash: v1alpha1.TiFlashSpec.Config: readObjectStart: expect { or n, but found ", error found in #10 byte of ...|"config":"## Log lev|..., bigger context ...|s":[{"topologyKey":"zone"}]},"tiflash":{"config":"## Log levels: trace, debug, info, warning, error,|...
it should be:
config:
config: |
TOML-format...
proxy: |
we should validate the spec first make it failed to be created
there are maybe other components we should check together
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.