pingcap / pingcap/tidb-operator

Redesign backup status conditions

Open
#3,912 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/api area/backup priority:P2 status/discussion-wanted
Dominant language
Go
Stars
1.3k
Forks
540
Avg merge
3d 2h
Merged PRs (30d)
18

Description

Now backup status condition is not well designed to obey kubernetes api convention

  • Use condition type as phase
  • Some condition is not reasonable(e.g. Running, Prepare)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked Kubernetes API conventions and then locate the backup status condition implementation in the operator. Done means the condition types follow the stated API convention and unreasonable conditions such as Running and Prepare are resolved, but the issue does not name files or tests to guide that work.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
backend-api-design, infrastructure
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.