pingcap / pingcap/tidb-operator
Operator should only upgrade statefulset that is manged by it
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Bug Report
What did you do?
- Deploy an operator using kubernetes built-in Statefulset.
- Deploy an operator with different controllerManager. selector value, and set feature AdvancedStatefulSet=true, which means using
AdvancedStatefulset.
What did you expect to see?
These two operators won't influence each other.
What did you see instead?
When the operator with feature AdvancedStatefulSet=true was deployed, it upgraded all the built-in StatefulSets in kubernetes into AdvancedStatefulSet, some of them belong to the TidbCluster that should not be managed by this operator.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review charts/tidb-operator/values.yaml, especially the controllerManager.selector and AdvancedStatefulSet settings, then trace the StatefulSet upgrade path. Done means an operator upgrades only StatefulSets belonging to its configured selector, while independently deployed operators do not affect each other.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100