pingcap / pingcap/tidb-operator
MaxBackups behavior on BackupSchedule
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Feature Request
Is your feature request related to a problem? Please describe:
https://asktug.com/t/topic/66829
When maxBackups calculating the number of backup copies,
it doesn't consider whether the status of the existing Backup is "Complete", "Failed", or "Running".
Backups with the status "Failed" will also be counted in maxBackups.
If a continuous failure is caused by some reason, it may result in a good backup being rotated out due to the setting of maxBackups.
Describe the feature you'd like:
Check the Backup object status when counting maxBackups, only calculate the object whose status is completed.
Describe alternatives you've considered:
Teachability, Documentation, Adoption, Migration Strategy:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.