pingcap / pingcap/tidb-operator
Remove dependency with the firstTC and firstDC in the TidbMonitor controller
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Feature Request
Is your feature request related to a problem? Please describe:
During the sync of TidbMonitor, we retrieve the TidbCluster info and DMCluster info from the first TidbCluster and DMCluster, which implies that we only support monitoring multiple clusters with the same configurations.
However, this is not a good practice when we want to support monitoring multiple clusters with different configurations, we may have to find a way to remove the dependency with the TidbCluster and DMCluster directly.
Describe the feature you'd like:
Describe alternatives you've considered:
Teachability, Documentation, Adoption, Migration Strategy:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pkg/monitor/monitor/monitor_manager.go at the TidbCluster and DMCluster references around lines 86 and 116, then trace the TidbMonitor sync path. Define how monitoring should support clusters with different configurations and establish acceptance criteria for removing reliance on the first cluster objects.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure, observability-sre
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100