pingcap / pingcap/tidb-operator
Add clusterName validate at validation phase.
Open
Nobody has claimed this yet.
status/discussion-wanted
status/help-wanted
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Feature Request
**Is your feature request related to a problem?
We use clusterName to construct the name of sts, deployment, service and pod，the conditions of k8s for pod service name are as follows:
// * must be no more than 63 characters long.
// * must consist of lower case alphanumeric characters or '-'.
// * must start and end with an alphanumeric character.
Therefore, we can use the k8s method validation.IsQualifiedName to verify the name of the service and pod to be generated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the validation phase that handles clusterName and read Kubernetes validation.IsQualifiedName to confirm the required naming rules. Done means invalid clusterName values are rejected before the operator generates the related StatefulSet, Deployment, Service, and Pod names.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100