pingcap / pingcap/tidb-operator
maxReservedTime does not support `d` (day) unit
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Bug Report
What version of Kubernetes are you using?
v1.16
What version of TiDB Operator are you using?
v1.1.0
What did you do?
Configure scheduled backup with maxReservedTime 7d
What did you expect to see?
Backup before 7 days ago are cleaned by GC.
What did you see instead?
Backup is not cleaned because 7d is an invalid option:
E0622 23:02:46.534601 1 backup_schedule_manager.go:277] backup schedule prod/tidb-backup-e7ncrgbu, invalid MaxReservedTime 7d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating backup_schedule_manager.go and the MaxReservedTime validation that emits the reported error. Trace which duration units are accepted, then run the relevant backup-schedule tests or add coverage for 7d; done means scheduled-backup garbage collection accepts day-based retention without the invalid-option error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100