pingcap / pingcap/tidb-operator
Deduplication, abstract general sync method for resources
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.3k
- Forks
- 540
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 18
Description
Feature Request
Is your feature request related to a problem? Please describe:
tidb-controller-manager maintains a lot of reconcile functions such as syncPdHeadlessService, syncTiKVHeadlessService, which are almost same in logic. It would be more maintainable if we can abstract these logic to shared functions.
Teachability, Documentation, Adoption, Migration Strategy:
This proposal won't introduce user-facing changes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the reconcile entry points named in the issue, syncPdHeadlessService and syncTiKVHeadlessService, to identify their shared logic. Done means the duplicated resource-sync behavior is abstracted into a general method without user-facing changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100