pingcap / pingcap/tidb-binlog

drainer's metric name `Execute Time` seems not clear

Open
#953 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

severity/moderate type/bug
Dominant language
Go
Stars
291
Forks
131
Avg merge
5m
Merged PRs (30d)
2

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

draienr's metirc Execute Time seems not clear, user may think it is the SQL's execute time

  1. What did you expect to see?

maybe we should rename to a better name

  1. Please provide the relate downstream type and version of drainer.

c36b95347eb98737d87123ebc0038db83f4c524c

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the drainer metric definition for Execute Time, then trace where its name is exposed and documented. Done means selecting and applying a clearer metric name without losing the metric's intended meaning.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.