binlogctl failed to parse pd-urls
Open
Nobody has claimed this yet.
affects-6.1
affects-6.2
affects-6.3
affects-6.4
affects-6.5
affects-6.6
affects-7.0
affects-7.1
affects-7.5
affects-8.1
affects-8.5
severity/major
type/bug
- Dominant language
- Go
- Stars
- 291
- Forks
- 131
- Avg merge
- 5m
- Merged PRs (30d)
- 2
Description
Bug Report
Please answer these questions before submitting your issue. Thanks!
- What did you do?
./binlogctl -pd-urls="http://12.12.12.12:2379" -cmd pumps
-
What did you expect to see?
work normally -
What did you see instead?
2020/03/04 17:57:31 main.go:39: [error] parse cmd flags, error: parse EtcdURLs error: http://12.12.12.12:2379, address http://12.12.12.12:2379: too many colons in address
- Please provide the relate downstream type and version of drainer.
(rundrainer -Vin terminal to get drainer's version)
2.1.19
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the binlogctl command from the report with the supplied pd URL, then trace the EtcdURLs parsing reached by the flag handling. Confirm that the URL is accepted and that the pumps command runs normally without the reported “too many colons in address” error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100