pingcap / pingcap/tidb-binlog

Exclude tidb_binlog & other reserved database names out-of-box

Open
#905 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature-request
Dominant language
Go
Stars
291
Forks
131
Avg merge
5m
Merged PRs (30d)
2

Description

Feature Request

Is your feature request related to a problem? Please describe:

For the database migration that we're performing, we setup DM from Aurora to TiDB first. Then after the migration, we'll revert the replication to replicate from TiDB to Aurora using drainer.

As we switch the replication direction back and forth, we hit an issue where manual changes to tidb_binlog database propagate and break the replication.

Describe the feature you'd like:

In general, any reserved database names for TiDB tools should be excluded from replication pipeline out-of-box.

For instance, in addition to tidb_binlog, I can quickly think of the following:

  • dm_meta
  • sync_diff_inspector
  • tidb_loader

If we get a consensus on this, I think we can apply the same default rule to other replication tools too (e.g. DM).

Describe alternatives you've considered:

  • Manually add tidb_binlog to the ignore-schemas configuration

Teachability, Documentation, Adoption, Migration Strategy:

N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the existing ignore-schemas configuration and replication filters for tidb_binlog. Review how the other named tool databases are handled, then add coverage showing that reserved names are excluded by default without manual configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.