pingcap / pingcap/tidb-binlog

drainer should exhaust removed sources when merging

Open
#563 0 comments 0 reactions 1 assignee View on GitHub

@suzaku is already working on this.

Since Jan 15, 2020.

status/help-wanted
Dominant language
Go
Stars
291
Forks
131
Avg merge
5m
Merged PRs (30d)
2

Description

When a source is removed, RemoveSource should exhaust the channel and push its pending binlogs with strategy to avoid loss of pending binlogs in the channel.

Previous attempt to solve this problem: #500

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.