pingcap / pingcap/tidb-binlog

Drainer interrupts several times when meeting some incompatible DDLs

Open
#1,060 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature-request
Dominant language
Go
Stars
291
Forks
131
Avg merge
5m
Merged PRs (30d)
2

Description

Feature Request

Is your feature request related to a problem? Please describe:

When drainer replicates TiDB v4.0 to v2.0, it interrupts several times when meeting some incompatible DDLs. Every time we have to search drainer logs and add these DDL's commit ts to ignore-txn-commit-ts.

Describe the feature you'd like:

Check the downstream TiDB/MySQL's version and make replicated SQLs compatible with the downstream receiver.

Describe alternatives you've considered:

Add a feature like dm's binlog event filter.

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how drainer handles replicated DDLs and how it identifies the downstream TiDB/MySQL version. Define the incompatible DDL cases and the supported version combinations before choosing an approach. Done means replication no longer interrupts for covered incompatibilities and no longer requires manually adding commit timestamps to ignore-txn-commit-ts.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
data-engineering, databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.