readTimeout is too small for mysql loader
Open
Nobody has claimed this yet.
severity/moderate
type/bug
- Dominant language
- Go
- Stars
- 291
- Forks
- 131
- Avg merge
- 5m
- Merged PRs (30d)
- 2
Description
Bug Report
Please answer these questions before submitting your issue. Thanks!
- What did you do?
If possible, provide a recipe for reproducing the error.
The hardcoded readTimeout is too small, time consuming DML and DDL may easily timed out.
- What did you expect to see?
Extend the default readTimeout and provide a configuration for changing the value manually.
- What did you see instead?
Some DML and DDL are timed out.
- Please provide the relate downstream type and version of drainer.
(rundrainer -Vin terminal to get drainer's version)
v4.0.12
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect pkg/loader/util.go at the linked line to locate the hardcoded readTimeout, then trace how the MySQL loader receives configuration. Done means the default timeout accommodates time-consuming DML and DDL while the value can be changed manually.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, mysql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100