[P2][Logs] Reclassify expected events to lower log levels
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 56
- Forks
- 63
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 34
Description
Parent issue: #4691
Intent
Expected events such as normal retries, duplicate ready messages, stale epoch drops, and routine shutdowns are currently too visible at Info or Warn. This dilutes the signal of logs that actually require action. This task reclassifies expected events so default levels emphasize actionable conditions.
Modification points
- Review the targeted paths and identify events that are expected in steady-state or during routine recovery.
- Move those events to
Debugor sampledInfowhen they are useful for diagnosis but not actionable by default. - Keep
WarnandErrorfor events that indicate a real anomaly, user-visible impact, or operator action.
Entry points
logservice/logpuller/region_request_worker.go:214downstreamadapter/eventcollector/dispatcher_stat.go:615downstreamadapter/eventcollector/dispatcher_stat.go:681server/module_election.go:182pkg/etcd/client.go:286
Done criteria
- Default
Warnlogs are closer to events that need action. - Default
Infologs focus on important phase changes and diagnostic conclusions. - Expected routine events are still observable when debug or sampling is enabled.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the listed entry points: logservice/logpuller/region_request_worker.go:214, downstreamadapter/eventcollector/dispatcher_stat.go:615 and :681, server/module_election.go:182, and pkg/etcd/client.go:286. Identify routine events and adjust their levels or sampling so Warn and Error indicate actionable conditions while expected events remain visible through debug or sampling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability-sre
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100