pingcap / pingcap/ticdc

handleDispatcherHeartbeat does not check server id in eventBroker

Open
#4,646 0 comments 0 reactions 1 assignee View on GitHub

@asddongmen is already working on this.

Since Mar 30, 2026.

severity/minor type/bug
Dominant language
Go
Stars
56
Forks
63
Avg merge
2d 20h
Merged PRs (30d)
34

Description

At pkg/eventservice/event_broker.go:1243, when handling DispatcherProgress, it trusts the dispatcher identifier / serverID in the heartbeat payload. However, it does not verify whether the node sending this heartbeat is indeed the owner of the dispatcher. The actual message source of the heartbeat is clearly msg.From.String(), but when updating checkpoint / last heartbeat, it only looks at the payload. As a result, any event-collector node can construct a heartbeat containing the dispatcher ID of another node and refresh its lastReceivedHeartbeatTime for that node.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.