Optimize digest calculation for columnSchema with default value and original default value
Open
Nobody has claimed this yet.
severity/moderate
type/enhancement
- Dominant language
- Go
- Stars
- 56
- Forks
- 63
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 34
Description
consider GetDefaultValue() and GetOriginDefaultValue() in hashTableInfo
if !reflect.DeepEqual(col.GetDefaultValue(), columns[i].GetDefaultValue()) {
return false
}
if !reflect.DeepEqual(col.GetOriginDefaultValue(), columns[i].GetOriginDefaultValue()) {
return false
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate hashTableInfo and its digest comparison logic, then inspect how column defaults are currently compared. Ensure both GetDefaultValue() and GetOriginDefaultValue() are considered, and verify that digest comparisons distinguish columns when either value differs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100