pingcap / pingcap/ticdc

sink may not be closed if meet error during the initialization

Open
#1,365 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/sink severity/moderate type/bug
Dominant language
Go
Stars
56
Forks
63
Avg merge
2d 20h
Merged PRs (30d)
34

Description

When initialize the kafka sink and mysql sink, and error report, already allocated resouces, such as kafka producer, mysql db connections, may not released.

If error happen, should call sink close method to release resource.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the Kafka and MySQL sink initialization paths to identify resources allocated before an initialization error is returned. Trigger an initialization failure and verify that the sink close behavior releases those resources; add or update tests if the relevant sink tests are found.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kafka, mysql
Domain
backend, databases, stream-processing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.