remove rust has function if nullable = false?
Open
Nobody has claimed this yet.
- Dominant language
- CMake
- Stars
- 171
- Forks
- 242
- Avg merge
- 5d 21h
- Merged PRs (30d)
- 8
Description
refer https://github.com/pingcap/tikv/pull/965
For more safe, I think we should remove has function to avoid wrong use.
/cc @ngaut @BusyJay @disksing @shenli
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the referenced TiKV pull request https://github.com/pingcap/tikv/pull/965 and tracing how the Rust has function is generated or used for fields with nullable = false. Confirm the intended behavior with the surrounding protocol-buffer definitions and existing validation. Done means the unsafe or misleading has function is removed for non-nullable fields without breaking generated Rust usage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100