pingcap / pingcap/failpoint

Failpoints.Disable not remove failpath from fps.reg

Open
#80 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
895
Forks
67
PR merge metrics
No merged PRs in 30d

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
    I'm trying to iterate over failpoint.List() to obtain all the enabled failpoint keys. However, I'm also retrieving deprecated keys from the list.
  2. What did you expect to see?
    After calling failpoint.disable(key), the key should no longer be present in fps.reg
  3. What did you see instead?
    Now, even after I disable a failpoint key, I can still retrieve it once it has been enabled.4. Versions of the failpoint
    • failpoint-ctl version (run failpoint-ctl -V):

      (paste failpoint-ctl version here)
      ReleaseVersion None
      BuildTS None
      GitHash None
      GitBranch None
      GoVersion None
      

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the failpoint.List() and failpoint.Disable() entry points and inspect how enabled keys are stored in fps.reg. Reproduce the sequence of enabling, disabling, and listing a key, then verify that disabled keys no longer appear in the list.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.