Failpoints.Disable not remove failpath from fps.reg
Open
Nobody has claimed this yet.
bug
- Dominant language
- Go
- Stars
- 895
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Description
Bug Report
Please answer these questions before submitting your issue. Thanks!
- What did you do? If possible, provide a recipe for reproducing the error.
I'm trying to iterate overfailpoint.List()to obtain all the enabled failpoint keys. However, I'm also retrieving deprecated keys from the list. - What did you expect to see?
After calling failpoint.disable(key), the key should no longer be present in fps.reg - What did you see instead?
Now, even after I disable a failpoint key, I can still retrieve it once it has been enabled.4. Versions of the failpoint-
failpoint-ctl version (run
failpoint-ctl -V):(paste failpoint-ctl version here) ReleaseVersion None BuildTS None GitHash None GitBranch None GoVersion None
-
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the failpoint.List() and failpoint.Disable() entry points and inspect how enabled keys are stored in fps.reg. Reproduce the sequence of enabling, disabling, and listing a key, then verify that disabled keys no longer appear in the list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100