pingcap / pingcap/docs

varchar value should use quotation marks

Open
#4,951 5 comments 0 reactions 1 assignee View on GitHub

@TomShawn is already working on this.

Since Mar 3, 2021.

Dominant language
Python
Stars
617
Forks
724
Avg merge
2d 10h
Merged PRs (30d)
223

Description

Error Report

Please answer the following questions before submitting your issue. Thanks!

  1. What is the URL/path of the document related to this issue?

https://docs.pingcap.com/tidb/stable/garbage-collection-configuration
tikv_gc_enable
Enables or disables GC
Default: true

  1. How would you like to improve it?
    tikv_gc_enable
    Enables or disables GC
    Default:" true"

all variable value's type is varchar, so it should be include in quotes.

desc mysql.tidb;
+----------------+---------------+------+------+---------+-------+
| Field | Type | Null | Key | Default | Extra |
+----------------+---------------+------+------+---------+-------+
| VARIABLE_NAME | varchar(64) | NO | PRI | NULL | |
| VARIABLE_VALUE | varchar(1024) | YES | | NULL | |
| COMMENT | varchar(1024) | YES | | NULL | |
+----------------+---------------+------+------+---------+-------+

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.