pimutils / pimutils/vdirsyncer

Skip hrefs for broken remotes

Open
#863 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.9k
Forks
185
Avg merge
11h 49m
Merged PRs (30d)
1

Description

I'm running 0.16.9.dev0+gb5dd092.d20201113 from Arch AUR and run into an issue with a broken CalDAV remote (SmarterMail Enterprise Build 7661). It seems to poorly handle objects when URL encoding is required, failing to open these calendar events in its own UI and they don't seem to be available in its DAV endpoint either. During sync it hits the NotFoundError exception and I've not been able to get these objects manually with different combinations of encoding.

As it currently only affects a small number of events, all invites from other people, I'd like to be able to skip them for now. I've made a small proposal change in https://github.com/hvanderheide/vdirsyncer/commit/c1d12a42f700a1853220f2ff74963fafd0f75cf9 which adds an optional setting to do just that. Is this something worth considering at all, and would this be the right way to implement this feature?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the proposed change in commit c1d12a42f700a1853220f2ff74963fafd0f75cf9 and trace how sync handles NotFoundError for broken CalDAV objects. Done means an optional setting allows those objects to be skipped without stopping synchronization.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.