pimutils / pimutils/khal

'dark' and 'light' colours are identical, but with a different font weight

Open
#1,439 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.1k
Forks
233
Avg merge
1h 44m
Merged PRs (30d)
1

Description

Describe the bug
When setting colours for calendars, dark and light versions of 16-bit colours are identical, but the light version produces a bolded font. For example, setting a calendar's colour to brown produces the same colour as yellow, but with the font bolded. The same is true of other dark-light pairs -- dark red + light red, etc. The colours work just fine in other programs so I can only assume this is some sort of problem with khal.

To Reproduce
Ehhhh, I dunno, use khal in Kitty maybe?

Expected behavior
I would've expected yellow and brown to be different colours (the ones I have set in my Kitty conf, that is #fa9a00 and #804800 respectively)

Screenshots
If applicable, add screenshots to help explain your problem.

Here's a calendar with its colour set to brown:
Image
And another that has it set to yellow:
Image

OS, version, khal version and how you installed it:

Additional context
I'm using the Kitty terminal (v0.43.1)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the colour settings in khal 0.13.0 under Kitty, using the linked configuration and comparing the dark/light pairs described in the report. Trace khal’s calendar-colour rendering path; done means 16-bit colour pairs display distinct configured colours without the light variant changing font weight, with regression coverage added if the project’s existing tests support it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.