Alarm symbol in the agenda_event_format overflows line
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.1k
- Forks
- 233
- Avg merge
- 1h 44m
- Merged PRs (30d)
- 1
Description
Describe the bug:
If the view.agenda_event_format variable has the {alarm-symbol} in it and an event has an alarm, it will push the final character (either the frame or the last character of the description) to the next line.
To Reproduce:
- Set
view.frameto eithercolororwidth - Have a calendar event with an alarm
- Highlight that event in the agenda view
Expected behavior:
The frame should bound the agenda with no gaps, regardless of the agenda_event_format variable.
Screenshots:
Took a screencap to better show the issue. Unfortunately GitHub keeps saying the file is corrupted, so I uploaded it to YouTube. Link here: https://youtu.be/fzZ1AT6FZmE
OS, version, khal version and how you installed it:
- The output of khal --version:
khal, version 0.11.3.dev169+g754840c - Installation method: PyPI with
pipx - python version: 3.11
- OS: Arch Linux on kernel 6.7.4-arch1-1
- Your khal config file:
[calendars]
[[Test]]
path=~/.local/share/calendarsri/test-calendar/
color=auto
[locale]
timeformat = %H:%M
dateformat = %Y-%m-%d
longdateformat = %Y-%m-%d
datetimeformat = %Y-%m-%d %H:%M
longdatetimeformat = %Y-%m-%d %H:%M
firstweekday = 6
[default]
default_calendar = Test
highlight_event_days = true
enable_mouse = false
[highlight_days]
color = ''
[view]
frame = width
Additional context
I made a test calendar with the events shown in the video, including alarms and descriptions.
test-calendar.zip
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the overflow in the agenda view using the supplied test calendar, view.frame = width or color, and an event containing an alarm. Start by tracing the agenda rendering behavior for agenda_event_format and {alarm-symbol}; done means the frame remains continuous without moving the final character to the next line.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100