pimutils / pimutils/khal

multiple_on_overflow doesn't work for single digit days and fg highlighting

Open
#1,177 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.1k
Forks
233
Avg merge
1h 44m
Merged PRs (30d)
1

Description

If the highlight is applied to the foreground, the days 1-9 can only show one color. At the moment the displayed color seems to be randomly chosen on startup (both with the calendar command and in interactive mode).
Since the overflow color only applies for 3 or more calendars on the same date and the priority has no effect in interactive mode/disables the two color display in the calendar command, the more important event may be overlooked.

This could be fixed by applying the overflow for two calendars on single digits, setting bg highlight where no fg character can be colored, or adding a leading zero (which would look most consistent in my opinion).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the highlighting in both the calendar command and interactive mode using single-digit days with multiple calendars. Inspect the overflow and foreground/background highlighting paths; done when overlapping events on days 1–9 consistently expose the important colors without the reported random startup behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.