improperly imports events with ancient CREATED entry
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.1k
- Forks
- 233
- Avg merge
- 1h 44m
- Merged PRs (30d)
- 1
Description
khal import fails to import events containing this:
CREATED:00001231T000000T
Judging from internet chatter, such data seemingly originate from Google, and is arguably bogus (RFC 5545 does not explicitly constrain which years can be expressed, but no calendar agent stored the data in an RFC 5545 store in year 0).
The imported data has transformed the event to contain this:
CREATED:None
That data certainly is broken.
If arguably-bogus year-0 data cannot be preserved as-is, then khal should not mangle it into even more broken data.
One better option that some suggest and I find reasonable is to replace year 0 with year 1970. Other less ideal options are to skip the event or to halt the import routine.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the khal import path and reproduce the failure using an event containing CREATED:00001231T000000T. Trace how that value becomes CREATED:None, then check the import behavior against the issue's proposed handling of year 0. Done means the event is no longer mangled into None and the chosen behavior is covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100