pillarjs / pillarjs/multiparty
Feature (Security)Suggestion: Set the chmod of uploaded file
Open
Nobody has claimed this yet.
good first contribution
ideas
- Dominant language
- JavaScript
- Stars
- 1.3k
- Forks
- 164
- Avg merge
- 4h 16m
- Merged PRs (30d)
- 4
Description
so you could set this(fileChmodPerms) property in the object that is being sent to initialize this module
{..... , fileChmodPerms: 600 }, in order to prevent files to be executed on the machine.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the module initialization options and the code that creates uploaded files. Check how a fileChmodPerms value of 600 could be accepted and applied to uploaded files, then verify that the resulting permissions prevent execution. The issue does not mention a test file, so identify the relevant existing upload tests before confirming the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100